wuchong commented on a change in pull request #8762:
[FLINK-12844][table-planner-blink] Use default conversion class
LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink
URL: https://github.com/apache/flink/pull/8762#discussion_r300913745
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/codegen/calls/BuiltInMethods.scala
##########
@@ -232,24 +237,43 @@ object BuiltInMethods {
val NOW_OFFSET = Types.lookupMethod(
classOf[SqlDateTimeUtils], "now", classOf[Long])
- val DATE_FORMAT_STRING_STRING_STRING = Types.lookupMethod(
+ val DATE_FORMAT_STRING_STRING_STRING_TIME_ZONE = Types.lookupMethod(
Review comment:
We can remove all the TIME_ZONE suffix methods in this file. They are not
used anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services