carp84 commented on a change in pull request #8930: [FLINK-12955] HBase
LookupableTableSource
URL: https://github.com/apache/flink/pull/8930#discussion_r300953468
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSource.java
##########
@@ -75,7 +83,7 @@ public HBaseTableSource(Configuration conf, String
tableName) {
this.hBaseSchema = new HBaseTableSchema();
}
- private HBaseTableSource(Configuration conf, String tableName,
TableSchema tableSchema) {
+ public HBaseTableSource(Configuration conf, String tableName,
TableSchema tableSchema) {
Review comment:
Change the method visibility to package-private (no need to be public)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
