JingsongLi commented on a change in pull request #8762:
[FLINK-12844][table-planner-blink] Use default conversion class
LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink
URL: https://github.com/apache/flink/pull/8762#discussion_r300959311
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlDateTimeUtils.java
##########
@@ -160,24 +160,16 @@ public TimeZone getNewInstance(String tz) {
* type used for UDF parameters ({@link java.sql.Timestamp}).
*
* <p>The internal long represents the time milliseconds since January
1, 1970, 00:00:00 GMT.
- * So we don't need to take TimeZone into account.
+ * we need a TimeZone.
Review comment:
I'll change it to calcite's implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
