aljoscha commented on issue #8914: [FLINK-12929] Pass TypeInformation in addSource URL: https://github.com/apache/flink/pull/8914#issuecomment-509222425 I think it was somewhat well defined until this change: https://github.com/apache/flink/commit/e39699f3eb41517a7035a5e626c6bb20c6b70501#diff-8c6a04f65f5a61e021e96322e8b06432R1000 Before, the idea was that if the source implements `ResultTypeQueryable`, then that should take precedence. Otherwise we try to deduce a `TypeInformation`. I think we should go back to that, i.e. `ResultTypeQueryable` takes precedence (in `addSource()`). The fact that the Scala API uses `returns()` comes from the fact that there was no `StreamExecutionEnvironment.addSource(SourceFunction, TypeInformation)`. Nowadays, I think no internal methods should use `returns()`. For this PR, it means that we have to not call `returns()`, but always use the constructor. And then in the constructor we have to do the correct change to make `ResultTypeQueryable` take precedence.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
