[ 
https://issues.apache.org/jira/browse/FLINK-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880385#comment-16880385
 ] 

Konstantin Knauf commented on FLINK-13123:
------------------------------------------

The "-s" command for "cancel" has two effects: 
* a savepoint is created
* and optionally changing the savepoint path

The current "-s" command for "stop" is only used to optionally change the 
savepoint path. I think "-p" makes it clearer that this is different to "-s" 
for cancel and it is only used to specify the savepoint path.

> Align Stop/Cancel Commands in CLI and REST Interface and Improve Documentation
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-13123
>                 URL: https://issues.apache.org/jira/browse/FLINK-13123
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Konstantin Knauf
>            Assignee: Konstantin Knauf
>            Priority: Major
>
> Currently, the REST API and CLI around stopping and cancelling jobs are not 
> aligned in terms of terminology and the differences between {{cancel}} and 
> {{job}} are not as clear as they could be.
> I would like to make the following changes to the CLI: 
> * add deprecation warning for {{cancel -s}} command and redirect users to  
> {{stop}}
> * rename {{-s}} of {{stop}} command to {{-p}} for savepoint location. 
> Emphasize that this is optional, as a savepoint is taken in any case
> I would like to make the following changes to the REST API: 
> * Rename {{stop-with-savepoint}} to {{stop}} 
> * Log a Deprecation warning with /savepoints is used in conjuction with 
> cancel. 
> * Rename "endOfEventTime" to "drain" in accordance with the CLI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to