gyfora commented on issue #8410: [FLINK-11159] Allow configuration whether to fall back to savepoints for restore URL: https://github.com/apache/flink/pull/8410#issuecomment-509561771 @StephanEwen @zentol I agree with most comments, and as far as the logging, exception handling goes it should have been reviewed better. As for the comment related to operational config in ExecutionConfig. I think the main problem is the existence of CheckpointConfig. Most of the checkpointing related settings can only be configured there at the moment so it doesnt make sense to put something new only in flink-conf. That would be extremely confusing. I think we need to rework the whole CheckpointConfig logic to allow every single thing to be override from flink-conf.yaml. I was not aware that we are trying to avoid interface default methods in the Flink codebase, I am sorry. I think they can make code much cleaner by removing the need to introduce abstract classes everywhere. Overall I agree that we need to clean this up one way or the other, I am not opposed to reverting this before the 1.9.0 release.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
