xintongsong edited a comment on issue #8740: [FLINK-12763][runtime] Fail job 
immediately if tasks’ resource needs can not be satisfied.
URL: https://github.com/apache/flink/pull/8740#issuecomment-509587077
 
 
   Thank you for the review, @StephanEwen.
   I don't think this is a bug. If the required profile is equal to unknown, 
the `isMatching` will return `true` anyway according to the comparing logics. 
The `(required == UNKNOWN)` is only a shortcut to avoid comparing individual 
properties, bcause comparing object reference is much less work than comparing 
the properties. If we use `UNKNOWN.equals(required)` here, it will not speed up 
at all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to