kl0u commented on a change in pull request #9030: [FLINK-13123] Align
Stop/Cancel Commands in CLI and REST Interface and Improve Documentation
URL: https://github.com/apache/flink/pull/9030#discussion_r301558812
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/savepoints/stop/StopWithSavepointRequestBody.java
##########
@@ -55,6 +55,6 @@ public String getTargetDirectory() {
}
public boolean shouldAdvanceToEndOfEventTime() {
Review comment:
Maybe update the method name as well to `shouldDrain()` or sth along those
lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
