pnowojski commented on a change in pull request #9021: [hostfix][runtime] Make
checkpoints injection ordered with stop-with-savepoint
URL: https://github.com/apache/flink/pull/9021#discussion_r301593676
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -766,16 +770,6 @@ private boolean performCheckpoint(
}
}
- if (isRunning && syncSavepointLatch.isSet()) {
-
- final boolean checkpointWasAcked =
-
syncSavepointLatch.blockUntilCheckpointIsAcknowledged();
-
- if (checkpointWasAcked) {
- finishTask();
- }
- }
-
return result;
Review comment:
nit: I think you could inline `return true` and `return false` now, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
