NicoK opened a new pull request #9048: [FLINK-13173][tests] only run 
openSSL-based tests with flink.tests.with-openssl
URL: https://github.com/apache/flink/pull/9048
 
 
   ## What is the purpose of the change
   
   Rename `flink.tests.force-openssl` (introduced for Flink 1.9) to 
`flink.tests.with-openssl` and only run openSSL-based unit tests if this is 
set. This way, we avoid systems where the bundled dynamic libraries do not 
work. Travis seems to run fine and will have this property set.
   
   For examples of such scenarios and why (for now) we cannot rely on automatic 
openSSL detection, please refer to 
https://issues.apache.org/jira/browse/FLINK-13172.
   
   ## Brief change log
   
   - rename `flink.tests.force-openssl` to `flink.tests.with-openssl`
   - adapt `SSLUtilsTest` to the inverse logic and provide 
`SSLUtilsTest#AVAILABLE_SSL_PROVIDERS` accordingly
   
   ## Verifying this change
   
   I tested `SSLUtilsTest` in all combinations of having openSSL (not) 
available and w/o `flink.tests.with-openssl` so that openSSL is picked up or 
the test is failing if it is not.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to