[
https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900723#comment-14900723
]
ASF GitHub Bot commented on FLINK-2720:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1157#discussion_r39972364
--- Diff:
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyContext.java
---
@@ -53,6 +58,10 @@ public FlinkTopologyContext(final StormTopology
topology, final Map<Integer, Str
null, null);
}
+ public void setContext(final StreamingRuntimeContext context) {
--- End diff --
I would extend the constructor instead of `setContext`. Using the
constructor is less error prone because it forced to provide the
`RuntimeContext`. An additional call to `setContext` could be "forgotten" by a
programmer.
> Add Storm-CountMetric in flink-stormcompatibility
> -------------------------------------------------
>
> Key: FLINK-2720
> URL: https://issues.apache.org/jira/browse/FLINK-2720
> Project: Flink
> Issue Type: New Feature
> Components: Storm Compatibility
> Reporter: Huang Wei
> Assignee: Huang Wei
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Add the CountMetric for the first step of storm metrics:
> 1.Do a wrapper FlinkCountMetric for CountMetric
> 2.push the RuntimeContext in FlinkTopologyContext to use `addAccumulator`
> method for registering the metric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
