AjaxXu commented on a change in pull request #9027:
[FLINK-13161][table-blink-runtime]numBuckets calculate wrong in
BinaryHashBucketArea
URL: https://github.com/apache/flink/pull/9027#discussion_r301867812
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/hashtable/BinaryHashBucketArea.java
##########
@@ -203,7 +203,7 @@ private void resize(boolean spillingAllowed) throws
IOException {
int oldNumBuckets = numBuckets;
MemorySegment[] oldOverflowSegments = overflowSegments;
int newNumSegs = oldBuckets.length * 2;
- int newNumBuckets = MathUtils.roundDownToPowerOf2(newNumSegs <<
table.bucketsPerSegmentBits);
Review comment:
Actually, we make sure the oldBuckets.length is power of 2. So after resize
the the length is still be power of 2. And as @TsReaper mentioned, it will be
checked later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
