bowenli86 commented on a change in pull request #9039:
[FLINK-13170][table-planner] Planner should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#discussion_r301815920
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/PlannerBase.scala
##########
@@ -241,7 +241,20 @@ abstract class PlannerBase(
case Some(s) if JavaScalaConversionUtil.toScala(s.getCatalogTable)
.exists(_.isInstanceOf[CatalogTable]) =>
- val sinkProperties =
s.getCatalogTable.get().asInstanceOf[CatalogTable].toProperties
+ val catalog = catalogManager.getCatalog(s.getTablePath.get(0))
+ val catalogTable = s.getCatalogTable.get().asInstanceOf[CatalogTable]
+ if (catalog.isPresent && catalog.get().getTableFactory.isPresent) {
Review comment:
wondering what if catalog is not present?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
