JingsongLi commented on a change in pull request #9027:
[FLINK-13161][table-blink-runtime]numBuckets calculate wrong in
BinaryHashBucketArea
URL: https://github.com/apache/flink/pull/9027#discussion_r301872189
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/hashtable/BinaryHashBucketArea.java
##########
@@ -203,7 +203,7 @@ private void resize(boolean spillingAllowed) throws
IOException {
int oldNumBuckets = numBuckets;
MemorySegment[] oldOverflowSegments = overflowSegments;
int newNumSegs = oldBuckets.length * 2;
- int newNumBuckets = MathUtils.roundDownToPowerOf2(newNumSegs <<
table.bucketsPerSegmentBits);
Review comment:
Yeah,
> the buckets.length and numBuckets should be always power of 2, Otherwise,
it will result in wasting segment.
So we need add check condition to avoid inefficient or incorrect code. I
think check condition is used for this, it is not an expected way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
