[
https://issues.apache.org/jira/browse/FLINK-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900816#comment-14900816
]
ASF GitHub Bot commented on FLINK-2536:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1030#issuecomment-142014348
I reworked this quite heavily during merging. There were a lot of issues
that were against good Java style:
- Variables in the classes, rather than in methods
- The way references to threads were obtained
- Defining clear parameter checks and exceptions
- Handling InterruptedExceptions
- polling versus clear conditions when state can be checked
You can have a look at the code after my fixes, to see these issues in
context.
I would suggest to get a Java book (like "Effective Java", that is a good
one) and take this as a guideline for future work. This pull request took more
than 70 comments and still needed quite some rework (not for Flink-specific
issues, but all of it general Java style/efficiency/correctness). I am afraid
we cannot do that for every pull request, it would be completely overwhelming...
> Add a retry for SocketClientSink
> --------------------------------
>
> Key: FLINK-2536
> URL: https://issues.apache.org/jira/browse/FLINK-2536
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I found the SocketClientSink doesn`t use a re-connect when disconnect from
> the socket server or get exception.
> I`d like to add a re-connect like socket source for socket sink.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
