[
https://issues.apache.org/jira/browse/FLINK-13181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881747#comment-16881747
]
Jark Wu edited comment on FLINK-13181 at 7/10/19 5:40 AM:
----------------------------------------------------------
Hi [~hehuiyuan], thanks for opening this issue. Please have a discussion in
Jira to reach a consensus before creating pull request. Here is the detailed
contribution guideline:
[https://flink.apache.org/contributing/contribute-code.html#create-jira-ticket-and-reach-consensus]
Regarding to this issue, I would be against to add a constructor for
CsvTableSink, because this will make constructors to be more and more. A better
solution should be to add a Builder for CsvTableSink, like
{{CsvTableSource.Builder}}.
was (Author: jark):
Hi [~hehuiyuan], thanks for opening this issue. Please have discussion in Jira
to reach a consensus before creating pull request. Here is the detailed
contribution guideline:
[https://flink.apache.org/contributing/contribute-code.html#create-jira-ticket-and-reach-consensus]
Regarding to this issue, I would be against to add a constructor for
CsvTableSink, because this will make constructors to be more and more. A better
solution should be to add a Builder for CsvTableSink, like
\{{CsvTableSource.Builder}}.
> Add a constructor function to CsvTableSink
> ------------------------------------------
>
> Key: FLINK-13181
> URL: https://issues.apache.org/jira/browse/FLINK-13181
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / API
> Reporter: hehuiyuan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add a constructor function for parameters :
> @param path The output path to write the Table to.
> @param fieldDelim The field delimiter
> @param writeMode The write mode to specify whether existing files
> are overwritten or not.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
