[
https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901068#comment-14901068
]
ASF GitHub Bot commented on FLINK-2479:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1160
[FLINK-2479] Refactor runtime.operators.* tests
This PR refactors most runtime.operators tests to use the TupleGenerator
introduced in FLINK-2105.
The changes made can generally be summed up as replacing usages of Records
with Tuple2<Integer, String> and adjusting serializers/comparators accordingly.
I've added a few static helper methods to the TestData class to simplify
comparator/serializer(factory) creation.
One oddball change is the introduction of a separate IntPairComparator
whose hash() implementation uses the underlying IntComparators hash() method,
to be in line with the TupleComparators implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 2479_testdata_pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1160
----
commit d090d36117694d76850ad2b8cb05b19f57beb3c6
Author: zentol <[email protected]>
Date: 2015-09-20T17:10:26Z
[FLINK-2479] Refactor runtime.operators.* tests
----
> Refactoring of org.apache.flink.runtime.operators.testutils.TestData class
> --------------------------------------------------------------------------
>
> Key: FLINK-2479
> URL: https://issues.apache.org/jira/browse/FLINK-2479
> Project: Flink
> Issue Type: Task
> Components: Local Runtime
> Reporter: Ricky Pogalz
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: pre-apache
>
>
> Currently, there are still tests which use {{Record}} from the old record
> API. One of the test util classes is {{TestData}}, including {{Generator}}
> and some other classes still using {{Record}}. An alternative implementation
> of the {{Generator}} without {{Record}} already exists in the {{TestData}}
> class, namely {{TupleGenerator}}.
> Please replace the utility classes in {{TestData}} that still use {{Record}}
> and adapt all of its usages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
