pnowojski commented on a change in pull request #8559: [FLINK-12576][Network,
Metrics]Take localInputChannel into account when compute inputQueueLength
URL: https://github.com/apache/flink/pull/8559#discussion_r301981852
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -273,6 +273,8 @@ public int getNumberOfQueuedBuffers() {
for (InputChannel channel :
inputChannels.values()) {
if (channel instanceof
RemoteInputChannel) {
totalBuffers +=
((RemoteInputChannel) channel).getNumberOfQueuedBuffers();
+ } else if (channel instanceof
LocalInputChannel) {
Review comment:
I wouldn't change the current behaviour and contract, as that would require
more extensive testing/benchmarking. Maybe in the future we might want to re
think this, but I don't think this has a high priority right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
