wuchong commented on a change in pull request #8294:
[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace
TableConfig in blink-planner module.
URL: https://github.com/apache/flink/pull/8294#discussion_r302048257
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/util/WindowEmitStrategy.scala
##########
@@ -128,12 +151,59 @@ object WindowEmitStrategy {
// use min idle state retention time as allow lateness
tableConfig.getMinIdleStateRetentionTime
}
-
+ val enableEarlyFireDelay = tableConfig.getParameters.getBoolean(
+ SQL_EXEC_EMIT_EARLY_FIRE_ENABLED)
+ val earlyFireDelay = getMillisecondFromConfigDuration(
+ tableConfig, SQL_EXEC_EMIT_EARLY_FIRE_DELAY)
+ val enableLateFireDelay =
tableConfig.getParameters.getBoolean(SQL_EXEC_EMIT_LATE_FIRE_ENABLED)
+ val lateFireDelay = getMillisecondFromConfigDuration(
+ tableConfig, SQL_EXEC_EMIT_LATE_FIRE_DELAY)
new WindowEmitStrategy(
isEventTime,
isSessionWindow,
- tableConfig.getEarlyFireInterval,
- tableConfig.getLateFireInterval,
+ earlyFireDelay,
+ enableEarlyFireDelay,
+ lateFireDelay,
+ enableLateFireDelay,
allowLateness)
}
+
+ // It is a experimental config, will may be removed later.
+ @Experimental
+ val SQL_EXEC_EMIT_EARLY_FIRE_ENABLED: ConfigOption[Boolean] =
Review comment:
We have supported early-fire and late-fire, and have tests to cover that. I
think we need some way to configure the emit strategy if we want to keep the
tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
