twalthr commented on a change in pull request #9035: [FLINK-13168] [table]
clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner
URL: https://github.com/apache/flink/pull/9035#discussion_r302052948
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/datastream/StreamTableSourceScanRule.scala
##########
@@ -41,7 +41,7 @@ class StreamTableSourceScanRule
val scan: TableScan = call.rel(0).asInstanceOf[TableScan]
val sourceTable = scan.getTable.unwrap(classOf[TableSourceTable[_]])
- sourceTable != null && sourceTable.isStreaming
+ sourceTable != null && sourceTable.isStreamMode
Review comment:
nit: use `isStreamingMode` for consistent naming as in `EnvironmentSettings`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
