GJL commented on a change in pull request #9060: [FLINK-13145][tests] Run HA
dataset E2E test with new RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/9060#discussion_r302055257
##########
File path: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh
##########
@@ -53,20 +52,51 @@ function run_ha_test() {
wait_job_running ${JOB_ID}
- # start the watchdog that keeps the number of JMs stable
- start_ha_jm_watchdog 1 "StandaloneSessionClusterEntrypoint" start_jm_cmd
"8081"
-
+ local c
for (( c=0; c<${JM_KILLS}; c++ )); do
# kill the JM and wait for watchdog to
# create a new one which will take over
kill_single 'StandaloneSessionClusterEntrypoint'
wait_job_running ${JOB_ID}
done
- cancel_job ${JOB_ID}
+ for (( c=0; c<${TM_KILLS}; c++ )); do
+ sleep $(( ( RANDOM % 10 ) + 1 ))
+ kill_and_replace_random_task_manager
+ wait_job_running ${JOB_ID}
Review comment:
`wait_job_running` will terminate the script if the job does not become
running within a timeout (10s). Since we are not launching a new process by
invoking the function, the main script will exit. Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
