[
https://issues.apache.org/jira/browse/FLINK-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901398#comment-14901398
]
ASF GitHub Bot commented on FLINK-2683:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1147#issuecomment-142107041
Actually, I think the tests are okay. The triggers are part of some tests
only, because this is a unit test that checks many features independently.
- There are two tests that validate behavior of triggers (regular case
and exception case). Both hang with out a trigger.
- Many tests test parameterization, timestamp alignments, and scheduling.
They need no triggers or mock triggers, so those naturally run without proper
triggers.
- Some test define corner conditions around windowing / closing. These
are valid even if everything happens in close(), so they are correct as well.
- Some tests check pure closing behavior (emit trailing data, make sure
exceptions are propagated)
I will add another test that checks the correct operation of tumbling
window triggers, but aside from that, I think the test coverage is good.
> Add utilities for heap-backed keyed state in time panes
> -------------------------------------------------------
>
> Key: FLINK-2683
> URL: https://issues.apache.org/jira/browse/FLINK-2683
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 0.10
>
>
> Time panes are commonly used for aligned time windows (tumbling and sliding).
> These utilities would represent the panes with per-pane keyed state.
> The implementation must support:
> - Evicting panes efficiently
> - iterating over the union of all panes' state per key for all keys
> (computing the window function for all keys)
> - efficient append the state for a key in a random pane
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
