StefanRRichter commented on a change in pull request #9021: [hostfix][runtime]
Make checkpoints injection ordered with stop-with-savepoint
URL: https://github.com/apache/flink/pull/9021#discussion_r302106768
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SynchronousSavepointLatch.java
##########
@@ -59,61 +66,53 @@ void setCheckpointId(final long checkpointId) {
}
}
- boolean blockUntilCheckpointIsAcknowledged() throws Exception {
+ void blockUntilCheckpointIsAcknowledged() throws Exception {
synchronized (synchronizationPoint) {
- if (isSet() && !isDone()) {
+ if (completionResult == null && isSet()) {
waiting = true;
synchronizationPoint.wait();
Review comment:
This line looks broken. What about spurious wakeups or other parties calling
`notifyAll` on the object - in particular if this is the checkpoint lock that
is to expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
