pnowojski commented on a change in pull request #8925: [FLINK-12852][network]
Fix the deadlock occured when requesting exclusive buffers
URL: https://github.com/apache/flink/pull/8925#discussion_r302111140
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -140,6 +141,18 @@
" help relieve back-pressure caused by
unbalanced data distribution among the subpartitions. This value should be" +
" increased in case of higher round trip times
between nodes and/or larger number of machines in the cluster.");
+ /**
+ * The timeout for requesting exclusive buffers for each channel.
+ */
+ @Documentation.ExcludeFromDocumentation("This option is purely
implementation related, and may be removed as the implementation changes.")
+ public static final ConfigOption<Long>
NETWORK_EXCLUSIVE_BUFFERS_REQUEST_TIMEOUT_MILLISECONDS =
+
key("taskmanager.network.memory.exclusive-buffers-request-timeout-ms")
+ .defaultValue(30000L)
Review comment:
I don't know what's the good default value for this timeout. @StephanEwen do
you have any proposal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
