NicoK commented on a change in pull request #8990: [FLINK-13104][metrics]
Updated request callback to log warning on failure
URL: https://github.com/apache/flink/pull/8990#discussion_r302076269
##########
File path:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -119,9 +119,19 @@ public void close() {
client.connectionPool().evictAll();
}
- private static class EmptyCallback implements Callback {
+ /**
+ * A handler for OkHttpClient callback. In case of error or failure it
logs the error at warning level.
+ */
+ protected static class EmptyCallback implements Callback {
+
+ protected static final String FAILED_SENDING_REQUEST_TO_DATADOG
= "Failed to send request to Datadog (response code was {})";
Review comment:
if you're not using this multiple times, you should keep the message close
to the `log` call because the parameters should match
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
