KurtYoung commented on issue #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#issuecomment-510278277 Hi @fhueske and @twalthr , sorry we didn't do detail investigation about these APIs. And also changes like this should definitely have a broader and visible discussions, like in mailing list. For this particular API, it was intend to ease downstream users to the usage of current API. So they don't have to judge the sql statement's type to decide whether it's a query or update. It was planned and we just don't have enough resource to finish it earlier, sorry to cause the impression that we are rushing changes. But consider this API will having some concerns from you guys, I will discuss with @danny0405 if all functionality can be finished without this API change. Sorry for the inconvenience, and discussions like this should definitely happen before opening PR next time. Regarding to returning NULL of `sql()`, we discussed another approach is return a `Optional<Table>`, what do you think about this? @twalthr
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
