mans2singh commented on a change in pull request #8990: [FLINK-13104][metrics]
Updated request callback to log warning on failure
URL: https://github.com/apache/flink/pull/8990#discussion_r302332031
##########
File path:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -133,6 +143,11 @@ public void onFailure(Call call, IOException e) {
@Override
public void onResponse(Call call, Response response) throws
IOException {
+
+ if (!response.isSuccessful()) {
+
getLogger().warn(FAILED_SENDING_REQUEST_TO_DATADOG, response.code());
Review comment:
Removed getLogger, added response body to log message, and set log level for
onFailure to warn since in most scenarios log level is set higher than debug.
Please let me know if you think the log level should be debug for both cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
