mrzhangboss commented on a change in pull request #9064: [FLINK-13188][Runtime
/ State Backends][Test] Fix annotation type error in MockTtlStateTest
URL: https://github.com/apache/flink/pull/9064#discussion_r302333139
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/mock/MockKeyedStateBackend.java
##########
@@ -178,7 +179,7 @@ public void notifyCheckpointComplete(long checkpointId) {
public RunnableFuture<SnapshotResult<KeyedStateHandle>> snapshot(
long checkpointId,
long timestamp,
- @Nonnull CheckpointStreamFactory streamFactory,
+ @Nullable CheckpointStreamFactory streamFactory,
Review comment:
Thanks for review !
In
[MockStateBackend](https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/mock/MockStateBackend.java)
when call `snapshot` function it always create a `CheckpointStorage` object
with a `resolveCheckpointStorageLocation` function.In
`resolveCheckpointStorageLocation` it only return null back. Maybe just fix
this `resolveCheckpointStorageLocation` function in
[MockStateBackend](https://github.com/apache/flink/blob/master/flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/mock/MockStateBackend.java)
will better. What do you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
