klion26 commented on a change in pull request #9064: [FLINK-13188][Runtime /
State Backends][Test] Fix annotation type error in MockTtlStateTest
URL: https://github.com/apache/flink/pull/9064#discussion_r302390170
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/mock/MockKeyedStateBackend.java
##########
@@ -178,7 +179,7 @@ public void notifyCheckpointComplete(long checkpointId) {
public RunnableFuture<SnapshotResult<KeyedStateHandle>> snapshot(
long checkpointId,
long timestamp,
- @Nonnull CheckpointStreamFactory streamFactory,
+ @Nullable CheckpointStreamFactory streamFactory,
Review comment:
I can't reproduce your problem locally, All the tests passed on my laptop.
But I think If this failed on your machine, we may better make the
`streamFactory` not null instead of marking it as `@Nullable`. So yes, as you
analyzed, we may fix `MockStateBackend#resolveCheckpointStorageLocation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
