TsReaper commented on a change in pull request #9029: [FLINK-13118][jdbc]
Introduce JDBC table factory and bridge JDBC table source with streaming table
source
URL: https://github.com/apache/flink/pull/9029#discussion_r302394858
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCTableSource.java
##########
@@ -55,6 +89,16 @@ public JDBCTableSource(
.build();
Review comment:
Tests are already added in `JDBCTableSourceSinkFactoryITCase` (the
`testJDBCScanSourceWithProjection`). Currently look-up functions don't have
projection functionality (only scan table source have projections), so this bug
can't be tested out. I'll fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
