twalthr commented on a change in pull request #8294:
[FLINK-12348][table-planner-blink]Use TableConfig in api module to replace
TableConfig in blink-planner module.
URL: https://github.com/apache/flink/pull/8294#discussion_r302395152
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java
##########
@@ -70,6 +71,38 @@
*/
private long maxIdleStateRetentionTime = 0L;
+ /**
+ * A configuration object to hold all key/value configuration.
+ */
+ private Configuration configuration = new Configuration();
+
+ /**
+ * Returns all key/value configuration.
+ */
+ public Configuration getConfiguration() {
+ return configuration;
+ }
+
+ /**
+ * Adds the given key/value configuration.
+ *
+ * @param configuration key/value configuration to adds
+ */
+ public void addConfiguration(Configuration configuration) {
+ Preconditions.checkNotNull(configuration);
+ this.configuration.addAll(configuration);
+ }
+
+ /**
+ * Adds the given key/value pair.
+ *
+ * @param key the key of the key/value pair to be added
+ * @param value the value of the key/value pair to be added
+ */
+ public void setConf(String key, String value) {
Review comment:
Do we need this method? People can just use`tableConfig.getConfiguration()`
and have a variety of setters for int, boolean, etc. available. Otherwise I see
PRs coming that want to add additional methods and basically mirror
`Configuration`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
