JingsongLi commented on a change in pull request #8920: [FLINK-13024][table]
integrate FunctionCatalog with CatalogManager
URL: https://github.com/apache/flink/pull/8920#discussion_r302397113
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/logical/PushFilterIntoTableSourceScanRule.scala
##########
@@ -68,7 +68,7 @@ class PushFilterIntoTableSourceScanRule extends RelOptRule(
RexProgramExtractor.extractConjunctiveConditions(
program,
call.builder().getRexBuilder,
- new FunctionCatalog("default_catalog", "default_database"))
+ new FunctionCatalog(null))
Review comment:
I think there's a problem with the previous code here. There must be no
function in the freshly produced `FunctionCatalog`.
But if pass null to FunctionCatalog, there will be a NPE.
How about pass a `new CatalogManager(defaultCatalogName, new
GenericInMemoryCatalog)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
