carp84 commented on a change in pull request #9075: [FLINK-10245][hbase] Add an upsert table sink factory for HBase URL: https://github.com/apache/flink/pull/9075#discussion_r302377044
########## File path: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseOptions.java ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.addons.hbase; + +import javax.annotation.Nullable; + +import java.util.Objects; +import java.util.Optional; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Common Options for HBase. + */ +public class HBaseOptions { + + private final String tableName; + private final String zkQuorum; + @Nullable private final String zkNodeParent; + + private HBaseOptions(String tableName, String zkQuorum, String zkNodeParent) { Review comment: Add `@Nullable` annotation for the `zNodeParent` parameter since it will be assigned to a Nullable field. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
