wuchong commented on a change in pull request #9075: [FLINK-10245][hbase] Add
an upsert table sink factory for HBase
URL: https://github.com/apache/flink/pull/9075#discussion_r302406031
##########
File path:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java
##########
@@ -54,7 +54,7 @@
* @param qualifier the qualifier name
* @param clazz the data type of the qualifier
*/
- void addColumn(String family, String qualifier, Class<?> clazz) {
+ public void addColumn(String family, String qualifier, Class<?> clazz) {
Review comment:
The reason is we want to expose `HBaseTableSchema` to users. Because
`HBaseUpsertSinkFunction` accepts `HBaseTableSchema` as a parameter. If we want
users to construct a `HBaseUpsertSinkFunction` and used in DataStream, core
methods of `HBaseTableSchema` should also be exposed.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
