Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1159#issuecomment-142221347
Thank you for the thorough review @tillrohrmann. I removed the
`resolveAddress()` method. It had a lot of duplicates with
`findConnectingAddress()` and was only used in one other location.
I'm now using the `findConnectingAddress()` there as well.
Regarding a test: There is a little test for `findConnectingAddress()`, but
we should add another test for the feature. My main problem is that I would
really like to include the fix into 0.10-milestone-1, which seems to be blocked
on this PR.
I'm currently manually testing my change on YARN to see if everything is
working as expected ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
