Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/885#discussion_r40068542
  
    --- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
 ---
    @@ -96,7 +96,7 @@ under the License.
                        <plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-shade-plugin</artifactId>
    -                           <version>2.3</version>
    +                           <version>2.4.1</version>
    --- End diff --
    
    updating the maven-shade-version in the quickstarts is a good idea. They 
are not inheriting the version from the flink-parent pom.
    so the change is good !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to