KurtYoung commented on a change in pull request #9057: [FLINK-13121]
[table-planner-blink] Set batch properties to runtime in blink batch executor
URL: https://github.com/apache/flink/pull/9057#discussion_r302516352
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/batch/BatchExecExchange.scala
##########
@@ -116,25 +75,39 @@ class BatchExecExchange(
override def explainTerms(pw: RelWriter): RelWriter = {
super.explainTerms(pw)
- .itemIf("exchange_mode", requiredExchangeMode.orNull,
- requiredExchangeMode.contains(DataExchangeMode.BATCH))
+ .itemIf("shuffle_mode", requiredShuffleMode.orNull,
+ requiredShuffleMode.contains(ShuffleMode.BATCH))
}
//~ ExecNode methods
-----------------------------------------------------------
- def setRequiredDataExchangeMode(exchangeMode: DataExchangeMode): Unit = {
- require(exchangeMode != null)
- requiredExchangeMode = Some(exchangeMode)
+ def setRequiredShuffleMode(shuffleMode: ShuffleMode): Unit = {
+ require(shuffleMode != null)
+ requiredShuffleMode = Some(shuffleMode)
}
- private[flink] def getDataExchangeMode(tableConf: Configuration):
DataExchangeMode = {
- requiredExchangeMode match {
- case Some(mode) if mode eq DataExchangeMode.BATCH => mode
- case _ => DataExchangeMode.PIPELINED
+ private[flink] def getShuffleMode(tableConf: Configuration): ShuffleMode = {
+ requiredShuffleMode match {
+ case Some(mode) if mode eq ShuffleMode.BATCH => mode
+ case _ => getShuffleModeFromConfig(tableConf)
+ }
+ }
+
+ private def getShuffleModeFromConfig(tableConf: Configuration): ShuffleMode
= {
Review comment:
This method name is almost the same with previous one, it's confusing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
