wuchong commented on a change in pull request #9029: [FLINK-13118][jdbc]
Introduce JDBC table factory and bridge JDBC table source with streaming table
source
URL: https://github.com/apache/flink/pull/9029#discussion_r302531009
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericBetweenParametersProvider.java
##########
@@ -29,48 +31,66 @@
*
* <p>For example, if there's a table <CODE>BOOKS</CODE> with a numeric PK
<CODE>id</CODE>, using a query like:
* <PRE>
- * SELECT * FROM BOOKS WHERE id BETWEEN ? AND ?
+ * SELECT * FROM BOOKS WHERE id BETWEEN ? AND ?
* </PRE>
*
* <p>You can take advantage of this class to automatically generate the
parameters of the BETWEEN clause,
* based on the passed constructor parameters.
- *
*/
public class NumericBetweenParametersProvider implements
ParameterValuesProvider {
- private final long fetchSize;
private final long minVal;
private final long maxVal;
+ private long batchSize;
+ private int batchNum;
+
/**
* NumericBetweenParametersProvider constructor.
*
- * @param fetchSize the max distance between the produced from/to pairs
* @param minVal the lower bound of the produced "from" values
* @param maxVal the upper bound of the produced "to" values
*/
- public NumericBetweenParametersProvider(long fetchSize, long minVal,
long maxVal) {
- checkArgument(fetchSize > 0, "Fetch size must be greater than
0.");
- checkArgument(minVal <= maxVal, "Min value cannot be greater
than max value.");
- this.fetchSize = fetchSize;
+ public NumericBetweenParametersProvider(long minVal, long maxVal) {
Review comment:
IMO, if we introduce such a change. I would prefer the previous version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
