1u0 commented on issue #9021: [FLINK-13205][runtime] Make checkpoints injection ordered with stop-with-savepoint URL: https://github.com/apache/flink/pull/9021#issuecomment-510775742 I think the `finishTask()` doesn't need to be run with acquired `checkpointLock`. The reason is the same as for `cancelTask()` invocation in `cancel()` - currently, both invocations should have the same expectations in regard of holding the lock. So far, the `cancelTask()` call wasn't called under `checkpointLock`. What I'm not sure about, if the modified `StreamTask.notifyCheckpointComplete()` should be called within `SafetyNetCloseableRegistry` context or with `Task.closeNetworkResources()` call afterwards.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
