lirui-apache commented on a change in pull request #9039:
[FLINK-13170][table-planner] Planner should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#discussion_r302882806
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/plan/batch/sql/SinkTest.scala
##########
@@ -60,4 +67,25 @@ class SinkTest extends TableTestBase {
util.verifyPlan()
}
+ @Test
+ def testCatalogTableSink(): Unit = {
Review comment:
It seems this test case fails even with this PR. Because
`GenericInMemoryCatalog::getTableFactory` returns Optional.empty(). So it falls
back to the service discovery. Could you please verify on your side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
