beyond1920 commented on a change in pull request #9035: [FLINK-13168] [table]
clarify isBatch/isStreaming/isBounded flag in flink planner and blink planner
URL: https://github.com/apache/flink/pull/9035#discussion_r302885807
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/catalog/CatalogCalciteSchema.java
##########
@@ -39,10 +39,13 @@
private final String catalogName;
private final Catalog catalog;
+ // Flag that tells if the current planner should work in a batch or
streaming mode.
+ private final boolean isBatchMode;
Review comment:
Could we unify `isBatchMode ` and the following `isStreamingMode` to the
same name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
