kl0u commented on a change in pull request #9090: [FLINK-13124] Don't forward
exceptions when finishing SourceStreamTask
URL: https://github.com/apache/flink/pull/9090#discussion_r302885296
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -49,6 +49,12 @@
private volatile boolean externallyInducedCheckpoints;
+ /**
+ * Indicates whether this Task was purposefully finished (by
finishTask()), in this case we
+ * want to ignore exceptions thrown after finishing, to ensure shutdown
works smoothly.
+ */
+ private volatile boolean isFinished = false;
+
Review comment:
I would suggest to move this flag to the `StreamTask`. The reason is that
although for now it is used only in the `SourceStreamTask`, know if the job was
normally terminated or cancelled is a property relevant to all the
`StreamTask`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
