StefanRRichter commented on issue #9021: [FLINK-13205][runtime] Make 
checkpoints injection ordered with stop-with-savepoint
URL: https://github.com/apache/flink/pull/9021#issuecomment-510851587
 
 
   @kl0u What was even the reason to introduce `finishTask()`? For all 
production code usages it seems that it does effectively exactly the same as 
`cancelTask` and is also just used in one place. Should we not rather drop it 
and call `cancelTask()` instead? 
   
   @1u0 Can you explain a bit more why you are concerned about 
`SafetyNetCloseableRegistry` and changed `notifyCheckpointComplete` - what's 
the connection there?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to