kl0u commented on issue #9021: [FLINK-13205][runtime] Make checkpoints injection ordered with stop-with-savepoint URL: https://github.com/apache/flink/pull/9021#issuecomment-510855822 @StefanRRichter The reason for the `finishTask()` (in addition to the `cancelTask()`) is that we should provide methods that allow us to differentiate Flink's behaviour between normal termination and cancellation whenever we can. Not doing so has already led to some problems (e.g. the situation with UDFs not having a proper `close()` method for normal termination). The fact that for now the `finishTask()` only calls the cancelTask is coincidental and simply due to the fact that the `cancel()` is the only method in source function interface that allows us to get out of the run-loop. In fact, there is already a PR (https://github.com/apache/flink/pull/9090) which makes the two methods (`finishTask` and `cancelTask`) diverge.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
