godfreyhe commented on a change in pull request #9039:
[FLINK-13170][table-planner] Planner should get table factory from ca…
URL: https://github.com/apache/flink/pull/9039#discussion_r302950820
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/plan/batch/sql/SinkTest.scala
##########
@@ -60,4 +67,25 @@ class SinkTest extends TableTestBase {
util.verifyPlan()
}
+ @Test
+ def testCatalogTableSink(): Unit = {
Review comment:
oops.., i'm wrong before, i debug the case and stop at line 253 (`if
(sink.isPresent) {`), i thought it could be succeed. 😂😂
could you update `Mockito.atLeast(1)` to `Mockito.atLeast(2)` ? the first
time is `
Mockito.when[Optional[_]](catalog.getTableFactory).thenReturn(Optional.of(factory))
` and another is in `getTableSink` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
