pnowojski commented on a change in pull request #8742: [FLINK-11879] Add
validators for the uses of InputSelectable, BoundedOneInput and
BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#discussion_r302971201
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/CodeGenOperatorFactory.java
##########
@@ -59,7 +59,12 @@ public ChainingStrategy getChainingStrategy() {
@Override
public boolean isOperatorSelectiveReading() {
- return
InputSelectable.class.isAssignableFrom(generatedClass.getClass(Thread.currentThread().getContextClassLoader()));
+ return
InputSelectable.class.isAssignableFrom(getStreamOperatorClass(Thread.currentThread().getContextClassLoader()));
+ }
+
+ @Override
+ public Class<? extends StreamOperator>
getStreamOperatorClass(ClassLoader classLoader) {
Review comment:
this method is inconsistent with `isOperatorSelectiveReading()` api that
just uses `getContextClassLoader()`. Please make them consistent and use the
same mechanism: either passing `classLoader` in both places or using
`getContextClassLoader` in both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
