[
https://issues.apache.org/jira/browse/FLINK-13242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883984#comment-16883984
]
Andrey Zagrebin commented on FLINK-13242:
-----------------------------------------
There is at least a potential problem with the visibility of
_SlotManager.failUnfulfillableRequest_ in
_StandaloneResourceManagerTest#testStartupPeriod_.
The test checks _failUnfulfillableRequest_ directly in its thread but it is set
in the main RPC thread of _StandaloneResourceManager#initialize_.
I reproduced it only once locally when I tried the test first time in IDE.
I can submit a PR with a fix where
_StandaloneResourceManagerTest#testStartupPeriod_ queries
_isFailingUnfulfillableRequest()_ in the main thread of
_StandaloneResourceManager_.
Also as [[email protected]] noticed, we could use _getMainThreadExecutor()_
directly to schedule _setFailUnfulfillableRequest()_ in
_StandaloneResourceManager#initialize_.
cc [~StephanEwen] [~xintongsong]
> StandaloneResourceManagerTest fails on travis
> ---------------------------------------------
>
> Key: FLINK-13242
> URL: https://issues.apache.org/jira/browse/FLINK-13242
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.9.0
> Reporter: Chesnay Schepler
> Assignee: Andrey Zagrebin
> Priority: Blocker
> Fix For: 1.9.0, 1.10.0
>
>
> https://travis-ci.org/apache/flink/jobs/557696989
> {code}
> 08:28:06.475 [ERROR]
> testStartupPeriod(org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerTest)
> Time elapsed: 10.276 s <<< FAILURE!
> java.lang.AssertionError: condition was not fulfilled before the deadline
> at
> org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerTest.assertHappensUntil(StandaloneResourceManagerTest.java:114)
> at
> org.apache.flink.runtime.resourcemanager.StandaloneResourceManagerTest.testStartupPeriod(StandaloneResourceManagerTest.java:60)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
