wuchong commented on a change in pull request #9107: [FLINK-13253][jdbc]
Deadlock may occur in JDBCUpsertOutputFormat
URL: https://github.com/apache/flink/pull/9107#discussion_r303274382
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCUpsertOutputFormat.java
##########
@@ -184,15 +186,6 @@ public synchronized void close() throws IOException {
if (this.scheduledFuture != null) {
scheduledFuture.cancel(false);
this.scheduler.shutdown();
Review comment:
Should we change this to `shutdownNow()`? I think the async flusher can quit
now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
