sunhaibotb commented on a change in pull request #8742: [FLINK-11879] Add
validators for the uses of InputSelectable, BoundedOneInput and
BoundedMultiInput
URL: https://github.com/apache/flink/pull/8742#discussion_r303277000
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/CodeGenOperatorFactory.java
##########
@@ -59,7 +59,12 @@ public ChainingStrategy getChainingStrategy() {
@Override
public boolean isOperatorSelectiveReading() {
- return
InputSelectable.class.isAssignableFrom(generatedClass.getClass(Thread.currentThread().getContextClassLoader()));
+ return
InputSelectable.class.isAssignableFrom(getStreamOperatorClass(Thread.currentThread().getContextClassLoader()));
+ }
+
+ @Override
+ public Class<? extends StreamOperator>
getStreamOperatorClass(ClassLoader classLoader) {
Review comment:
Because a general method `getStreamOperatorClass()` is added,
`isOperatorSelectiveReading()` is not needed and can be dropped. It is planned
to drop `isOperatorSelectiveReading()` from the PR of the JIRA
(https://issues.apache.org/jira/browse/FLINK-13051), so no changes had been
made to make them consistent. But the best thing to do is to keep them
consistency first whether `isOperatorSelectiveReading()` is dropped or not. I
will solve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
