zentol commented on issue #9071: FLINK-13044 [BuildSystem / Shaded] Fix for wrong shading of AWS SDK in flink-s3-fs-hadoop URL: https://github.com/apache/flink/pull/9071#issuecomment-511368590 OK, let's see if I got this correctly: There are 2 issues here: 1) The shade-plugin relocates `S3FileSystemFactory#PACKAGE_PREFIXES_TO_SHADE`, as a result of which no value for `fs.s3a.aws.credentials.provider` that starts with `com.amazonaws` is relocated to the shaded namespace when creating the hadoop config in the `S3FileSystemFactory`. 2) The shading pattern configured for `com.amazonaws` is not synced between the shade-plugin and the `S3FileSystemFactory`. Even if 1) were fixed, we would still shade the configured value into the wrong namespace. Am I correct that we can test this by modifying our a3 end-to-end tests to set `fs.s3a.aws.credentials.provider: com.amazonaws.auth.DefaultAWSCredentialsProviderChain`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
